The following commit has been merged into the core/rcu branch of tip:

Commit-ID:     849b9c5446ccb0c98c7b11c69f169d22777ab31b
Gitweb:        
https://git.kernel.org/tip/849b9c5446ccb0c98c7b11c69f169d22777ab31b
Author:        kernel test robot <[email protected]>
AuthorDate:    Sun, 27 Sep 2020 15:00:29 +02:00
Committer:     Paul E. McKenney <[email protected]>
CommitterDate: Thu, 01 Oct 2020 09:07:24 -07:00

kvfree_rcu(): Fix ifnullfree.cocci warnings

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 16a6320addfc ("rcu/tree: Allocate a page when caller is preemptible")
Acked-by: Joel Fernandes (Google) <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
---
 kernel/rcu/tree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 39ac930..09dfd03 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_struct *work)
                                bkvhead[i] = NULL;
                        krc_this_cpu_unlock(krcp, flags);
 
-                       if (bkvhead[i])
-                               kfree(bkvhead[i]);
+                       kfree(bkvhead[i]);
 
                        cond_resched_tasks_rcu_qs();
                }

Reply via email to