Hi Andy, Thanks for the feedback.
>-----Original Message----- >From: Andy Shevchenko <[email protected]> >Sent: Thursday, October 8, 2020 4:46 PM >To: Zulkifli, Muhammad Husaini <[email protected]> >Cc: Hunter, Adrian <[email protected]>; Michal Simek ><[email protected]>; Shevchenko, Andriy ><[email protected]>; Ulf Hansson <[email protected]>; linux- >mmc <[email protected]>; linux-arm Mailing List <linux-arm- >[email protected]>; Linux Kernel Mailing List <linux- >[email protected]>; Raja Subramanian, Lakshmi Bai ><[email protected]>; Wan Mohamad, Wan Ahmad Zainie ><[email protected]>; Arnd Bergmann ><[email protected]> >Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted >Firmware Service call > >On Thu, Oct 8, 2020 at 5:48 AM <[email protected]> wrote: >> >> From: Muhammad Husaini Zulkifli <[email protected]> >> >> Add header file to handle API function for device driver to >> communicate with Arm Trusted Firmware. > >Arm -> ARM ? I will rename based on Sudeep's mentioned in latest thread > >... > >> .../linux/firmware/intel/keembay_firmware.h | 47 +++++++++++++++++++ > >Please, drop dup of 'firmware' in the filename. Noted. Will change to keembay.h > >... > >> +/* >> + * Intel Keembay SOC Firmware API Layer >> + * > >> + * Copyright (C) 2020-2021, Intel Corporation > >Hello from the future? > Will edit to Copyright (C) 2020, Intel Corporation >> + * >> + * Muhammad Husaini Zulkifli <[email protected]> > >Author: ... > >> + */ > >... > >> +/* >> + * This file defines API function that can be called by device driver >> +in order to > >an API >by a device Noted 😊 > >> + * communicate with Arm Trusted Firmware. > >Arm -> ARM ? I will rename based on Sudeep's mentioned in latest thread > >> + */ > >-- >With Best Regards, >Andy Shevchenko
