Using full paths to extend or override a device tree node is error prone
since if there was a typo error, a new node will be created instead of
extending the node as it was desired.  This will lead to run-time errors
that could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
 arch/arm/boot/dts/exynos4210.dtsi | 36 +++++++++++++++----------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi 
b/arch/arm/boot/dts/exynos4210.dtsi
index 73360f29d53e..fddc661ded28 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -365,26 +365,24 @@
                        };
                };
        };
+};
 
-       thermal-zones {
-               cpu_thermal: cpu-thermal {
-                       polling-delay-passive = <0>;
-                       polling-delay = <0>;
-                       thermal-sensors = <&tmu 0>;
-
-                       trips {
-                               cpu_alert0: cpu-alert-0 {
-                                       temperature = <85000>; /* millicelsius 
*/
-                               };
-                               cpu_alert1: cpu-alert-1 {
-                                       temperature = <100000>; /* millicelsius 
*/
-                               };
-                               cpu_alert2: cpu-alert-2 {
-                                       temperature = <110000>; /* millicelsius 
*/
-                               };
-                       };
-               };
-       };
+&cpu_alert0 {
+       temperature = <85000>; /* millicelsius */
+};
+
+&cpu_alert1 {
+       temperature = <100000>; /* millicelsius */
+};
+
+&cpu_alert2 {
+       temperature = <110000>; /* millicelsius */
+};
+
+&cpu_thermal {
+       polling-delay-passive = <0>;
+       polling-delay = <0>;
+       thermal-sensors = <&tmu 0>;
 };
 
 &gic {
-- 
2.17.1

Reply via email to