Hi Rob, Thanks a lot for your review!
Regards, Zhiqiang > -----Original Message----- > From: Rob Herring <[email protected]> > Sent: 2020年8月18日 21:52 > To: Z.q. Hou <[email protected]> > Cc: [email protected]; PCI <[email protected]>; Lorenzo > Pieralisi <[email protected]>; Bjorn Helgaas > <[email protected]>; Andrew Murray > <[email protected]>; Jingoo Han <[email protected]>; > Gustavo Pimentel <[email protected]> > Subject: Re: [PATCHv2] PCI: designware-ep: Fix the Header Type check > > On Tue, Aug 18, 2020 at 3:35 AM Zhiqiang Hou <[email protected]> > wrote: > > > > From: Hou Zhiqiang <[email protected]> > > > > The current check will result in the multiple function device fails to > > initialize. So fix the check by masking out the multiple function bit. > > > > Fixes: 0b24134f7888 ("PCI: dwc: Add validation that PCIe core is set > > to correct mode") > > Signed-off-by: Hou Zhiqiang <[email protected]> > > --- > > V2: > > - Add marco PCI_HEADER_TYPE_MASK and print the masked value. > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 3 ++- > > include/uapi/linux/pci_regs.h | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > Reviewed-by: Rob Herring <[email protected]>
