On Mon, Nov 05, 2007 at 11:27:31AM +0100, Cornelia Huck wrote: > On Fri, 2 Nov 2007 16:59:24 -0700, > Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: > > > Dynamically create the kset instead of declaring it statically. > > This makes the kobject attributes now work properly that I broke in the > > previous patch. > > > > Cc: Kay Sievers <[EMAIL PROTECTED]> > > Cc: Michael Holzheu <[EMAIL PROTECTED]> > > Cc: Heiko Carstens <[EMAIL PROTECTED]> > > Cc: Volker Sameske <[EMAIL PROTECTED]> > > Cc: Cornelia Huck <[EMAIL PROTECTED]> > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > --- > > arch/s390/kernel/ipl.c | 75 > > +++++++++++++++++++++++++----------------------- > > 1 files changed, 39 insertions(+), 36 deletions(-) > > It seems you also need this (not yet booted): > > Fix the following warnings: > > arch/s390/kernel/ipl.c: In function 'reipl_init': > arch/s390/kernel/ipl.c:981: warning: passing argument 2 of > 'sysfs_create_file' from incompatible pointer type > arch/s390/kernel/ipl.c: In function 'dump_init': > arch/s390/kernel/ipl.c:1070: warning: passing argument 2 of > 'sysfs_create_file' from incompatible pointer type > arch/s390/kernel/ipl.c: In function 'shutdown_actions_init': > arch/s390/kernel/ipl.c:1094: warning: passing argument 2 of > 'sysfs_create_file' from incompatible pointer type > > Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]>
Thanks, but this should go with the previous kobject_attribute cleanup patch, not the kset patch. I've merged it in now. thanks for the review and patch. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
