Hi Stephen, > From: Stephen Rothwell <[email protected]> > Sent: Saturday, July 18, 2020 9:39 AM > To: Randy Dunlap <[email protected]> > Cc: Linux Next Mailing List <[email protected]>; Linux Kernel Mailing > List <[email protected]>; [email protected]; Alessandro > Zummo <[email protected]>; Alexandre Belloni > <[email protected]>; Scott Wood <[email protected]>; > Johnson CH Chen (陳昭勳) <[email protected]> > Subject: Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o) > > Hi Randy, > > [Please trim your emails a bit more, thanks] > > On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <[email protected]> > wrote: > > on x86_64: > > # CONFIG_WATCHDOG is not set > >
Thanks for your information. It seems RTC_DRV_DS1374_WDT should be depended on RTC_DRV_DS1374 && WATCHDOG_CORE. Otherwise error will happen if RTC_DRV_DS1374_WDT is enabled but WATCHDOG_CORE not. I'll put this into v5 if there are no other suggestions. Should I add " Reported-by: Stephen Rothwell <[email protected]>" into v5? So many thanks! > > ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe': > > rtc-ds1374.c:(.text+0x736): undefined reference to > `watchdog_init_timeout' > > ld: rtc-ds1374.c:(.text+0x77e): undefined reference to > `devm_watchdog_register_device' > > Caused by commit > > d3de4beb14a8 ("rtc: ds1374: wdt: Use watchdog core for watchdog > part") > > from the rtc tree. > -- > Cheers, > Stephen Rothwell Best regards, Johnson
