On Wed, Jul 8, 2020 at 1:28 AM Anson Huang <[email protected]> wrote:
> subsys_initcall(gpio_mxc_init);
> +
> +MODULE_AUTHOR("Shawn Guo <[email protected]>");
> +MODULE_DESCRIPTION("i.MX GPIO Driver");
> +MODULE_LICENSE("GPL");
You are making this modualrizable but keeping the subsys_initcall(),
which doesn't make very much sense. It is obviously not necessary
to do this probe at subsys_initcall() time, right?
Take this opportunity to convert the driver to use
module_platform_driver() as well.
Yours,
Linus Walleij
