Ard Biesheuvel <[email protected]> writes: > On Tue, 12 May 2020 at 06:55, Punit Agrawal > <[email protected]> wrote: >> >> While debugging a boot failure, the following unknown error record was >> seen in the boot logs. >> >> <...> >> BERT: Error records from previous boot: >> [Hardware Error]: event severity: fatal >> [Hardware Error]: Error 0, type: fatal >> [Hardware Error]: section type: unknown, >> 81212a96-09ed-4996-9471-8d729c8e69ed >> [Hardware Error]: section length: 0x290 >> [Hardware Error]: 00000000: 00000001 00000000 00000000 00020002 >> ................ >> [Hardware Error]: 00000010: 00020002 0000001f 00000320 00000000 >> ........ ....... >> [Hardware Error]: 00000020: 00000000 00000000 00000000 00000000 >> ................ >> [Hardware Error]: 00000030: 00000000 00000000 00000000 00000000 >> ................ >> <...> >> >> On further investigation, it was found that the error record with >> UUID (81212a96-09ed-4996-9471-8d729c8e69ed) has been defined in the >> UEFI Specification at least since v2.4 and has recently had additional >> fields defined in v2.7 Section N.2.10 Firmware Error Record Reference. >> >> Add support for parsing and printing the defined fields to give users >> a chance to figure out what went wrong. >> >> Signed-off-by: Punit Agrawal <[email protected]> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: "Rafael J. Wysocki" <[email protected]> >> Cc: Borislav Petkov <[email protected]> >> Cc: James Morse <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> --- >> Hi Ard, >> >> I've updated the patch based on your feedback. >> >> As you noted, some aspects of the spec make it a bit tricky to support >> all revisions in a nice way (e.g., size check) but this version should >> fix existing issues. >> >> Thanks, >> Punit >> >> v1[0] -> v2: >> * Simplified error record structure definition >> * Fixed size check >> * Added comment to clarify offset calculation for dumped data >> * Style fixes for multiline if blocks > > Thanks. I will queue this as a fix.
Thanks! Just for my understanding - are you planning to send this for v5.7 or v5.8? There's no rush, so I am fine either ways. [...]
