On Wed, 29 Apr 2020 23:19:25 +0200, Ansuel Smith wrote:
> Document dwc3 qcom phy hs and ss phy bindings needed to correctly
> inizialize and use usb on ipq806x SoC.
>
> Signed-off-by: Ansuel Smith <[email protected]>
> ---
> v4:
> * Add qcom to specific bindings
> v3:
> * Use explicit reg instead of regmap
>
> .../bindings/phy/qcom,ipq806x-usb-phy-hs.yaml | 58 +++++++++++++++
> .../bindings/phy/qcom,ipq806x-usb-phy-ss.yaml | 73 +++++++++++++++++++
> 2 files changed, 131 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-hs.yaml
> create mode 100644
> Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
properties:qcom,tx_deamp_3_5db: {'maxItems': 1, 'description': 'Override value
for transmit preemphasis.', 'default': 23} is not valid under any of the given
schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
properties:qcom,tx_deamp_3_5db: 'not' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
properties:qcom,rx_eq: {'maxItems': 1, 'description': 'Override value for
rx_eq.', 'default': 4} is not valid under any of the given schemas (Possible
causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
properties:qcom,rx_eq: 'not' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
properties:qcom,mpll: {'maxItems': 1, 'description': 'Override value for
mpll.', 'default': 0} is not valid under any of the given schemas (Possible
causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
properties:qcom,mpll: 'not' is a required property
Documentation/devicetree/bindings/Makefile:11: recipe for target
'Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.example.dts'
failed
make[1]: ***
[Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.example.dts]
Error 1
make[1]: *** Waiting for unfinished jobs....
warning: no schema found in file:
Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
ignoring, error in schema: properties: qcom,mpll
warning: no schema found in file:
Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml:
ignoring, error in schema: properties: qcom,mpll
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1279692
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
--upgrade
Please check and re-submit.
