On Fri, Sep 27, 2019 at 12:49 AM Jose Abreu <[email protected]> wrote: > > The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it.
I think the warning was from -Wsizeof-array-div. > > Reported-by: kbuild test robot <[email protected]> > Reported-by: Nick Desaulniers <[email protected]> I may have reported the kbuild link, but scanning my email, there's also a report from Reported-by: Nathan Chancellor <[email protected]> > Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core") > Signed-off-by: Jose Abreu <[email protected]> > > --- > Cc: Giuseppe Cavallaro <[email protected]> > Cc: Alexandre Torgue <[email protected]> > Cc: Jose Abreu <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Maxime Coquelin <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: Nick Desaulniers <[email protected]> > --- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > index 6d8ac2ef4fc2..4a1f52474dbc 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > @@ -533,7 +533,7 @@ static int dwxgmac2_rss_configure(struct mac_device_info > *hw, > return 0; > } > > - for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) { > + for (i = 0; i < (ARRAY_SIZE(cfg->key) / sizeof(u32)); i++) { cfg is an instance of struct stmmac_rss, which looks like: 125 struct stmmac_rss { 126 int enable; 127 u8 key[STMMAC_RSS_HASH_KEY_SIZE]; 128 u32 table[STMMAC_RSS_MAX_TABLE_SIZE]; 129 }; yep, LGTM. Thanks for the patch. Reviewed-by: Nick Desaulniers <[email protected]> > ret = dwxgmac2_rss_write_reg(ioaddr, true, i, cfg->key[i]); > if (ret) > return ret; > -- > 2.7.4 > -- Thanks, ~Nick Desaulniers
