On Wednesday 25 September 2019 11:07:35 Andy Shevchenko wrote: > On Mon, Sep 23, 2019 at 4:24 PM <[email protected]> wrote: > > > From: Pali Rohár <[email protected]> > > > Sent: Sunday, September 22, 2019 8:43 AM > > > To: Pacien TRAN-GIRARD > > > Cc: Matthew Garrett; Darren Hart; Andy Shevchenko; platform-driver- > > > [email protected]; [email protected]; Limonciello, Mario > > > Subject: Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight > > > on > > > Inspiron 10xx > > > > We need to wait what Mario wrote about this particular problem. > > > > > > > I agree an Inspiron is unlikely to be updated 9 years later. I think the > > right thing > > to do in this instance is to blacklist this particular platform in kernel > > driver. > > Does it mean you are okay with the proposed patch? Can you give your tag then?
I would rather use different name as kbd_phantom_backlight. E.g. lbd_broken_backlight or something which indicates non-working / disabled support. Also in commit message is written that problem is with KBD_LED_OFF_TOKEN and KBD_LED_ON_TOKEN tokens, but proposed patch does not blacklist these tokens, but rather turn off whole kbd functionality. So proposed patch does not patch commit message, nor explain it. -- Pali Rohár [email protected]
