On Tue, Sep 24, 2019 at 08:44:20AM +0200, Christian Brauner wrote:
> Afaict, the struct seccomp_data argument to secure_computing() is unused
> by all current callers. So let's remove it.
> The argument was added in [1]. It was added because having the arch
> supply the syscall arguments used to be faster than having it done by
> secure_computing() (cf. Andy's comment in [2]). This is not true anymore
> though.
>
> /* References */
> [1]: 2f275de5d1ed ("seccomp: Add a seccomp_data parameter secure_computing()")
> [2]:
> https://lore.kernel.org/r/calcetru_fs_at-htpr231kpaad0z7xjn4ku-dvzhru6cvcj...@mail.gmail.com
>
> Signed-off-by: Christian Brauner <[email protected]>
> Cc: Andy Lutomirski <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Will Drewry <[email protected]>
> Cc: Oleg Nesterov <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> /* v1 */
> - Borislav Petkov <[email protected]>:
> - provide context for the arg addition to secure_computing() in the
> commit message
>
> /* v0 */
> Link:
> https://lore.kernel.org/r/[email protected]
> ---
> arch/arm/kernel/ptrace.c | 2 +-
> arch/arm64/kernel/ptrace.c | 2 +-
> arch/parisc/kernel/ptrace.c | 2 +-
> arch/s390/kernel/ptrace.c | 4 ++--
> arch/um/kernel/skas/syscall.c | 2 +-
> arch/x86/entry/vsyscall/vsyscall_64.c | 2 +-
> include/linux/seccomp.h | 6 +++---
> 7 files changed, 10 insertions(+), 10 deletions(-)
Acked-by: Borislav Petkov <[email protected]>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
