On Mon, Sep 09, 2019 at 09:50:08PM +0200, Arnd Bergmann wrote:
> The newly added code triggers a harmless warning with
> clang:
>
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1080:9: error:
> implicit conversion from enumeration type 'enum mlx5_reformat_ctx_type' to
> different enumeration type 'enum mlx5dr_action_type'
> [-Werror,-Wenum-conversion]
> rt = MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;
> ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1084:51: error:
> implicit conversion from enumeration type 'enum mlx5dr_action_type' to
> different enumeration type 'enum mlx5_reformat_ctx_type'
> [-Werror,-Wenum-conversion]
> ret = mlx5dr_cmd_create_reformat_ctx(dmn->mdev, rt, data_sz,
> data,
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~
>
> Change it to use mlx5_reformat_ctx_type instead of mlx5dr_action_type.
>
> Fixes: 9db810ed2d37 ("net/mlx5: DR, Expose steering action functionality")
> Signed-off-by: Arnd Bergmann <[email protected]>
I sent the same fix a couple of days ago:
https://lore.kernel.org/netdev/[email protected]/
I don't care which patch goes in since they are the same thing so:
Reviewed-by: Nathan Chancellor <[email protected]>
