Re: [PATCH V40 03/29] security: Add a static lockdown policy LSM

[David Howells]

Matthew Garrett <matthewgarr...@google.com> wrote:

> +static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = {

const char *const maybe?

> +static enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE,
> +                                              LOCKDOWN_INTEGRITY_MAX,
> +                                              LOCKDOWN_CONFIDENTIALITY_MAX};
> +

const?

Isn't this also a 1:1 mapping?

> +static int lock_kernel_down(const char *where, enum lockdown_reason level)

Is the last parameter the reason or the level?  You're mixing the terms.

David