CC Niklas, who has the hardware On Thu, Jul 11, 2019 at 10:29 AM Bartosz Golaszewski <[email protected]> wrote: > From: Bartosz Golaszewski <[email protected]> > > In commit 8764c4ca5049 ("gpio: em: use the managed version of > gpiochip_add_data()") we implicitly altered the ordering of resource > freeing: since gpiochip_remove() calls gpiochip_irqchip_remove() > internally, we now can potentially use the irq_domain after it was > destroyed in the remove() callback (as devm resources are freed after > remove() has returned). > > Use devm_add_action_or_reset() to keep the ordering right and entirely > kill the remove() callback in the driver. > > Reported-by: Geert Uytterhoeven <[email protected]> > Fixes: 8764c4ca5049 ("gpio: em: use the managed version of > gpiochip_add_data()") > Cc: [email protected] > Signed-off-by: Bartosz Golaszewski <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
