On 20.06.19 18:05, Nathan Chancellor wrote: > On Thu, Jun 20, 2019 at 12:35:18PM +0200, David Hildenbrand wrote: >> walk_memory_range() was once used to iterate over sections. Now, it >> iterates over memory blocks. Rename the function, fixup the >> documentation. Also, pass start+size instead of PFNs, which is what most >> callers already have at hand. (we'll rework link_mem_sections() most >> probably soon) >> >> Follow-up patches wil rework, simplify, and move walk_memory_blocks() to >> drivers/base/memory.c. >> >> Note: walk_memory_blocks() only works correctly right now if the >> start_pfn is aligned to a section start. This is the case right now, >> but we'll generalize the function in a follow up patch so the semantics >> match the documentation. >> >> Cc: Benjamin Herrenschmidt <[email protected]> >> Cc: Paul Mackerras <[email protected]> >> Cc: Michael Ellerman <[email protected]> >> Cc: "Rafael J. Wysocki" <[email protected]> >> Cc: Len Brown <[email protected]> >> Cc: Greg Kroah-Hartman <[email protected]> >> Cc: David Hildenbrand <[email protected]> >> Cc: Rashmica Gupta <[email protected]> >> Cc: Andrew Morton <[email protected]> >> Cc: Pavel Tatashin <[email protected]> >> Cc: Anshuman Khandual <[email protected]> >> Cc: Michael Neuling <[email protected]> >> Cc: Thomas Gleixner <[email protected]> >> Cc: Oscar Salvador <[email protected]> >> Cc: Michal Hocko <[email protected]> >> Cc: Wei Yang <[email protected]> >> Cc: Juergen Gross <[email protected]> >> Cc: Qian Cai <[email protected]> >> Cc: Arun KS <[email protected]> >> Signed-off-by: David Hildenbrand <[email protected]> >> --- >> arch/powerpc/platforms/powernv/memtrace.c | 22 ++++++++++----------- >> drivers/acpi/acpi_memhotplug.c | 19 ++++-------------- >> drivers/base/node.c | 5 +++-- >> include/linux/memory_hotplug.h | 2 +- >> mm/memory_hotplug.c | 24 ++++++++++++----------- >> 5 files changed, 32 insertions(+), 40 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powernv/memtrace.c >> b/arch/powerpc/platforms/powernv/memtrace.c >> index 5e53c1392d3b..8c82c041afe6 100644 >> --- a/arch/powerpc/platforms/powernv/memtrace.c >> +++ b/arch/powerpc/platforms/powernv/memtrace.c >> @@ -70,23 +70,24 @@ static int change_memblock_state(struct memory_block >> *mem, void *arg) >> /* called with device_hotplug_lock held */ >> static bool memtrace_offline_pages(u32 nid, u64 start_pfn, u64 nr_pages) >> { >> + const unsigned long start = PFN_PHYS(start_pfn); >> + const unsigned long size = PFN_PHYS(nr_pages); >> u64 end_pfn = start_pfn + nr_pages - 1; > > This variable should be removed: > > arch/powerpc/platforms/powernv/memtrace.c:75:6: warning: unused variable > 'end_pfn' [-Wunused-variable] > u64 end_pfn = start_pfn + nr_pages - 1; > ^ > 1 warning generated. > > https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/209576737 > > Cheers, > Nathan >
Indeed, thanks! -- Thanks, David / dhildenb
