On Tue, Jun 18, 2019 at 11:51:18AM +0530, Nisha Kumari wrote: > On 6/13/2019 10:55 PM, Mark Brown wrote:
> > > + labibb->lab_vreg.vreg_enabled = 1;
> > What function does this serve? It never seems to be read.
> Its used in next patch for handling interrupts
It'd be better to move this code into the patch where it's used then.
> > > + if (val & IBB_STATUS1_VREG_OK_BIT) {
> > > + labibb->ibb_vreg.vreg_enabled = 1;
> > > + return 0;
> > > + }
> > > + }
> > This is doing more than the other regulator was but it's not clear why -
> > is it just that the delays are different for the two regulators?
> LAB regulator comes up in first try, so we did not added much delay in that
> like IBB. Planning to make equal no of retries for both in next patch so
> that code can be reused.
Is there actually a need for polling at all?
signature.asc
Description: PGP signature
