Hi Kefeng,
On Tue, 18 Jun 2019 04:22:02 +0100,
Kefeng Wang <[email protected]> wrote:
>
> After commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> it will print "____ptrval____" instead of actual addresses when mbigen
> create domain fails,
>
> Hisilicon MBIGEN-V2 HISI0152:00: Failed to create mbi-gen@(____ptrval____)
> irqdomain
> Hisilicon MBIGEN-V2: probe of HISI0152:00 failed with error -12
>
> Instead of changing the print to "%px", and leaking kernel addresses,
> just remove the print completely.
>
> Signed-off-by: Kefeng Wang <[email protected]>
> ---
> drivers/irqchip/irq-mbigen.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
> index 98b6e1d4b1a6..d0cf596c801b 100644
> --- a/drivers/irqchip/irq-mbigen.c
> +++ b/drivers/irqchip/irq-mbigen.c
> @@ -355,8 +355,7 @@ static int mbigen_device_probe(struct platform_device
> *pdev)
> err = -EINVAL;
>
> if (err) {
> - dev_err(&pdev->dev, "Failed to create mbi-gen@%p irqdomain",
> - mgn_chip->base);
> + dev_err(&pdev->dev, "Failed to create mbi-gen irqdomain");
The alternative would be to print res as a resource, which would still
help identifying the offending device by printing its physical
layout, and still not reveal much.
Just let me know what you prefer.
Thanks,
M.
> return err;
> }
>
> --
> 2.20.1
>
--
Jazz is not dead, it just smells funny.
