Re: [PATCH net-next 01/12] net: hns3: log detail error info of ROCEE ECC and AXI errors

[tanhuazhong]

On 2019/6/7 1:36, David Miller wrote:

From: Huazhong Tan <tanhuazh...@huawei.com>
Date: Thu, 6 Jun 2019 16:20:56 +0800

+static int hclge_log_rocee_axi_error(struct hclge_dev *hdev)
+{

  ...

+       ret = hclge_cmd_send(&hdev->hw, &desc[0], 3);
+       if (ret) {
+               dev_err(dev, "failed(%d) to query ROCEE AXI error sts\n", ret);
+               return ret;
+       }

  ...

+               ret = hclge_log_rocee_axi_error(hdev);
+               if (ret) {
+                       dev_err(dev, "failed(%d) to process axi error\n", ret);

You log the error twice which is unnecessary.

ok, thanks.

.