Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in hardware

[Luck, Tony]

On Fri, May 17, 2019 at 09:34:31PM +0200, Borislav Petkov wrote:
> On Fri, May 17, 2019 at 11:06:07AM -0700, Luck, Tony wrote:
> > and thus end up with that extra level on indent for the rest
> > of the function.
> 
> Ok:
> 
> @@ -1569,7 +1575,13 @@ static void __mcheck_cpu_init_clear_banks(void)
>  
>               if (!b->init)
>                       continue;
> +
> +             /* Check if any bits are implemented in h/w */
>               wrmsrl(msr_ops.ctl(i), b->ctl);
> +             rdmsrl(msr_ops.ctl(i), msrval);
> +
> +             b->init = !!msrval;
> +
>               wrmsrl(msr_ops.status(i), 0);
>       }

Much neater :-)

Acked-by: Tony Luck <tony.l...@intel.com>