On Tue, Apr 30, 2019 at 09:12:49PM -0500, Bjorn Helgaas wrote:
> On Tue, Apr 30, 2019 at 12:18:13PM -0600, Keith Busch wrote:
> > On Tue, Apr 30, 2019 at 12:05:09PM -0600, Keith Busch wrote:
> > > On Tue, Apr 30, 2019 at 11:11:51AM -0500, Bjorn Helgaas wrote:
> > > > > I'm not convinced a revert is the best call.
> > > >
> > > > I have very limited options at this stage of the release, but I'd be
> > > > glad to hear suggestions. My concern is that if we release v5.1
> > > > as-is, we'll spend a lot of energy on those false positives.
> > >
> > > May be too late now if the revert is queued up, but I think this feature
> > > should have been a default 'false' Kconfig bool rather than always on.
>
> Since this feature currently just adds a message in dmesg, which we
> don't really consider a stable API, I think a Kconfig switch is a
> reasonable option.
>
> If you send me a signed-off-by for the following patch, I can apply it:
Sounds good, I'll need to resend though since I messed up the Makefile:
> +obj-$(CONFIG_PCIE_BW) := bw_notification.o
s/:=/+=
