On 26/04/2019 11.39, Arnd Bergmann wrote: > On Tue, Apr 9, 2019 at 11:26 PM Rasmus Villemoes > <[email protected]> wrote: >> >> Similar to GENERIC_BUG_RELATIVE_POINTERS, one can now relativize the >> four const char* members of struct _ddebug, thus saving 16 bytes per >> instance (one for each pr_debug(), dev_debug() etc. in a >> CONFIG_DYNAMIC_DEBUG kernel). The asm-generic implementation seems to >> work out-of-the-box, though this is only compile-tested. >> >> Signed-off-by: Rasmus Villemoes <[email protected]> > > This causes a build regression when compiling with clang, > see > http://staging-storage.kernelci.org/next-clang/master/next-20190424/arm64/allmodconfig/clang-8/build.log
Yes, see also https://github.com/ClangBuiltLinux/linux/issues/456 . The quickest short-term fix is to append "if CC_IS_GCC" to the select statements. Then when a fix lands in clang one can change that to "if CC_IS_GCC || CLANG_VERSION >= something". It's probably best if we fix -next builds ASAP instead of waiting for knowing the proper value of "something". Nathan, Nick, WDYT? I had 0day verify my patches before sending them out officially, and thought it also did clang builds. But apparently not, or not with enough arch/.config combinations? Rasmus
