And simplify the code a bit.

Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Jiri Olsa <[email protected]>
---
 tools/perf/util/header.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 7bebf9a34edd..06e11e9ad05e 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1042,11 +1042,9 @@ static int write_cpuid(struct feat_fd *ff,
        int ret;
 
        ret = get_cpuid(buffer, sizeof(buffer));
-       if (!ret)
-               goto write_it;
+       if (ret)
+               return -1;
 
-       return -1;
-write_it:
        return do_write_string(ff, buffer);
 }
 
-- 
2.17.2

Reply via email to