Hi,
On 05/02/2019 23:18, Stephen Boyd wrote:
> Quoting Neil Armstrong (2019-02-04 01:13:30)
>> + * Register offsets from the data sheet must be multiplied by 4.
>> + */
>> +#define AO_RTI_STATUS_REG3 0x0C
>> +#define AO_RTI_PWR_CNTL_REG0 0x10
>> +#define AO_RTI_GEN_CNTL_REG0 0x40
>> +#define AO_CLK_GATE0 0x4c
>> +#define AO_CLK_GATE0_SP 0x50
>> +#define AO_OSCIN_CNTL 0x58
>> +#define AO_CEC_CLK_CNTL_REG0 0x74
>> +#define AO_CEC_CLK_CNTL_REG1 0x78
>> +#define AO_SAR_CLK 0x90
>> +#define AO_RTC_ALT_CLK_CNTL0 0x94
>> +#define AO_RTC_ALT_CLK_CNTL1 0x98
>> +
>> +#define AXG_AO_GATE(_name, _reg, _bit) \
>> +static struct clk_regmap g12a_aoclk_##_name = {
>> \
>> + .data = &(struct clk_regmap_gate_data) { \
>> + .offset = (_reg), \
>> + .bit_idx = (_bit), \
>> + }, \
>> + .hw.init = &(struct clk_init_data) { \
>> + .name = "g12a_ao_" #_name, \
>> + .ops = &clk_regmap_gate_ops, \
>> + .parent_names = (const char *[]){ IN_PREFIX "mpeg-clk" }, \
>> + .num_parents = 1, \
>> + .flags = CLK_IGNORE_UNUSED, \
>
> Can you please add a comment explaining why CLK_IGNORE_UNUSED is here?
> It will help future readers know what's going on with this special flag.
>
Sure, I'll add it.
Neil
