Hi Jagan. Looks good, only very few nits left.
On Sat, Jan 26, 2019 at 12:52:33AM +0530, Jagan Teki wrote: > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > Add panel driver for it. > > Tested-by: Bhushan Shah <[email protected]> > Signed-off-by: Jagan Teki <[email protected]> If you consider my inputs (I know you will) then you can add my: Reviewed-by: Sam Ravnborg <[email protected]> > + msleep(20); > + > + gpiod_set_value(ctx->reset, 0); > + /* T5 + T6 (avdd rise + video & logic signal rise) > + * T5 >= 10ms, 0 < T6 <= 10ms > + */ > + msleep(20); Please use kernel coding style comment, and maybe an empty line between gpiod...() and the comment: gpiod_set_value(ctx->reset, 0); /* * T5 + T6 (avdd rise + video & logic signal rise) * T5 >= 10ms, 0 < T6 <= 10ms */ msleep(20); > +static int feiyang_get_modes(struct drm_panel *panel) > +{ > + struct drm_connector *connector = panel->connector; > + struct feiyang *ctx = panel_to_feiyang(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(panel->drm, &feiyang_default_mode); > + if (!mode) { > + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", > + feiyang_default_mode.hdisplay, > + feiyang_default_mode.vdisplay, > + feiyang_default_mode.vrefresh); Please consider to use DRM_MODE_FMT and DRM_MODE_ARG for printing. > +static const struct of_device_id feiyang_of_match[] = { > + { .compatible = "feiyang,fy07024di26a30d", }, > + { } Maybe use { /* sentinel */ }, ?
