Oleg Nesterov <[email protected]> writes: > On 11/27, Jürg Billeter wrote: >> >> @@ -704,6 +713,9 @@ static void exit_notify(struct task_struct *tsk, int >> group_dead) >> struct task_struct *p, *n; >> LIST_HEAD(dead); >> >> + if (group_dead && tsk->signal->kill_descendants_on_exit) >> + walk_process_tree(tsk, kill_descendant_visitor, NULL); > > Well, this is not exactly right, at least this is suboptimal in that > other sub-threads can too call walk_process_tree(kill_descendant_visitor) > later for no reason.
Oleg I think I am missing something. Reading kernel/exit.c I see "group_dead = atomic_dec_and_test(&tsk->signal->live)". Which seems like enough to ensure exactly one task/thread calls walk_process_tree. Can you explain what I am missing? Eric
