On 11/26/18 4:22 PM, Jaegeuk Kim wrote:
On 11/27, Stephen Rothwell wrote:
[..]
Oh, thanks~ Is this okay?
Yep. This fix the warning. :) Thanks, Jaegeuk -- Gustavo
From 79e24f1509e5b6a07069be9cc8163969da78c57a Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim <[email protected]> Date: Mon, 26 Nov 2018 14:20:32 -0800 Subject: [PATCH] f2fs: avoid build warn of fall_through After merging the f2fs tree, today's linux-next build (x86_64_allmodconfig) produced this warning: In file included from fs/f2fs/dir.c:11: fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag': fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (set) ^ fs/f2fs/f2fs.h:2390:2: note: here case FI_DATA_EXIST: ^~~~ Exposed by my use of -Wimplicit-fallthrough Reported-by: Stephen Rothwell <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]> --- fs/f2fs/f2fs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 26ad1de8641c..b3fe6803d4c6 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode, case FI_NEW_INODE: if (set) return; + /* fall through */ case FI_DATA_EXIST: case FI_INLINE_DOTS: case FI_PIN_FILE:
