On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote:
> The SDC2 control pins are typically used to manage sleep.
>
> Signed-off-by: Jeffrey Hugo <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 78
> ++++++++++++++++++++++++++++++
Rather than adding a -pins file, add the pinctrl states the individual
dts(i) directly.
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +
> 2 files changed, 80 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> new file mode 100644
> index 0000000..a22abf9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> @@ -0,0 +1,78 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2018, The Linux Foundation. All rights reserved. */
> +
> +&tlmm {
> + sdc2_clk_on: sdc2_clk_on {
Use _ in labels, - in node names.
> + config {
You don't have to put the pinctrl state properties in an additional
subnode anymore, so feel free to remove the extra subnode level.
> + pins = "sdc2_clk";
> + bias-disable; /* NO pull */
> + drive-strength = <16>; /* 16 MA */
Please push electrical properties to the board dts instead of the
platform one, as they might be board specific.
> + };
> + };
Apart from this the patch loogs good.
Regards,
Bjorn
