Kees Cook <[email protected]> writes: > On Thu, Nov 15, 2018 at 10:05 AM, Stefan Wahren <[email protected]> > wrote: >> Hi James, >> >> please look at >> https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html, >> because there are several issues with this patch. Most critical one is >> that i received it not as plain text. Please make sure that send your >> patch with git send-email. > > The irony is I had to fight Gmail over your multipart HTML+plain > email. Yay email clients! ;) > >> Am 15.11.18 um 14:18 schrieb James Hughes: >> > A previous change (5bfdc1097654) moved away from VLA's >> >> Please use the commit format mentioned in the link above. > > And actually, this SHA isn't the upstream SHA. This should be: > > a1547e0bca51 ("firmware: raspberrypi: Remove VLA usage") > >> > to a fixed maximum size for mailbox data. >> > However, some mailbox calls use larger data buffers >> > than the maximum allowed in that change. This fix therefor > > Which ones did this? In the initial change I couldn't find anything > that exceeded 32 bytes. (I'm just curious if I missed something or if > something new appeared.)
Nothing in tree used larger, it's that there are firmware transactions that are bigger. >> > [...] >> > + /* Some mailboxes can use over 1k bytes. Rather than checking > > Up to Eric, but I think the preferred comment style is: > > /* > * lines go here > */ > > Otherwise, this seems fine to me. Thanks for getting it fixed! I have no preference about comment style, I just want fixes to land. :)
signature.asc
Description: PGP signature
