On Wed, Oct 31, 2018 at 12:57:37AM +0300, Vasily Averin wrote:
> currently bh is set to NULL only during first iteration of for cycle,
> then this pointer is not cleared after end of using.
> Therefore rollback after errors can lead to extra brelse(bh) call,
> decrements bh counter and later trigger an unexpected warning in __brelse()
>
> Patch moves brelse() calls in body of cycle to exclude requirement of
> brelse() call in rollback.
>
> Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") #
> 3.3+
>
> Signed-off-by: Vasily Averin <[email protected]>
Thanks, applied. I addjusted the patch summary to read:
ext4: avoid potential extra brelse in setup_new_flex_group_blocks()
(Note that resise should have been spelled as "resize", by the way.)
- Ted
