On Sun, 1 Jul 2007 19:37:49 +0400 Oleg Nesterov <[EMAIL PROTECTED]> wrote:
> I don't know how to test this patch, the ack/nack from maintainer is wanted. > > flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc() > and release_dev() to use cancel_delayed_work_sync/cancel_work_sync. > > I am not sure we really need to call do_tty_hangup() when cancel_work_sync() > returns true, but this matches the current behaviour. > > Also, some whitespace fixes. > > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> I'm sorry but the tty layer hangup code is not in a shape to do these changes. Please leave it alone until the revoke() code in 2.6.2x-mm is ready for mainstream then we will switch to that and all the mess goes away. Its just *too* fragile to touch otherwise, and we've had repeated breakages from tiny changes in this area. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
