From: Søren Andersen <[email protected]> Add support for specifying the quartz load in the DT node. The pcf8523 may use either a 7 pF or an 12.5 pF xtal. If the rtc has the wrong configuration the time will drift several hours/week.
If nothing is specified in DT then the factory default of 7 pF is used. This is a change compared to before where the driver assumed 12.5 pF. Note: all kernel dts trees are updated with the new property. Signed-off-by: Søren Andersen <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Cc: Alessandro Zummo <[email protected]> Cc: Alexandre Belloni <[email protected]> --- drivers/rtc/rtc-pcf8523.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 453615f8ac9a..3c19b4d21a2d 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -85,7 +85,7 @@ static int pcf8523_write(struct i2c_client *client, u8 reg, u8 value) return 0; } -static int pcf8523_select_capacitance(struct i2c_client *client, bool high) +static int pcf8523_select_capacitance(struct i2c_client *client) { u8 value; int err; @@ -94,7 +94,7 @@ static int pcf8523_select_capacitance(struct i2c_client *client, bool high) if (err < 0) return err; - if (!high) + if (!device_property_present(&client->dev, "nxp,quartz_load_12.5pf")) value &= ~REG_CONTROL1_CAP_SEL; else value |= REG_CONTROL1_CAP_SEL; @@ -331,7 +331,7 @@ static int pcf8523_probe(struct i2c_client *client, if (!pcf) return -ENOMEM; - err = pcf8523_select_capacitance(client, true); + err = pcf8523_select_capacitance(client); if (err < 0) return err; -- 2.12.0
