Hi Matthias, On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote: > Currently update_devfreq() is only visible to devfreq governors outside > of devfreq.c. Make it public to allow drivers that adjust devfreq policies > to cause a re-evaluation of the frequency after a policy change. > > Signed-off-by: Matthias Kaehlcke <[email protected]> > Acked-by: MyungJoo Ham <[email protected]> > Reviewed-by: Brian Norris <[email protected]> > -- > Changes in v5: > - none > > Changed in v4: > - added 'Reviewed-by: Brian Norris <[email protected]>' tag > > Changes in v3: > - none > > Changes in v2: > - added 'Acked-by: MyungJoo Ham <[email protected]>' tag > --- > drivers/devfreq/governor.h | 3 --- > include/linux/devfreq.h | 8 ++++++++ > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h > index b81700244ce3..f53339ca610f 100644 > --- a/drivers/devfreq/governor.h > +++ b/drivers/devfreq/governor.h > @@ -57,9 +57,6 @@ struct devfreq_governor { > unsigned int event, void *data); > }; > > -/* Caution: devfreq->lock must be locked before calling update_devfreq */ > -extern int update_devfreq(struct devfreq *devfreq); > - > extern void devfreq_monitor_start(struct devfreq *devfreq); > extern void devfreq_monitor_stop(struct devfreq *devfreq); > extern void devfreq_monitor_suspend(struct devfreq *devfreq); > diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h > index 7c8dce96db73..c4f84a769cb5 100644 > --- a/include/linux/devfreq.h > +++ b/include/linux/devfreq.h > @@ -222,6 +222,14 @@ extern void devm_devfreq_remove_device(struct device > *dev, > extern int devfreq_suspend_device(struct devfreq *devfreq); > extern int devfreq_resume_device(struct devfreq *devfreq); > > +/** > + * update_devfreq() - Reevaluate the device and configure frequency > + * @devfreq: the devfreq device > + * > + * Note: devfreq->lock must be held > + */ > +extern int update_devfreq(struct devfreq *devfreq); > + > /* Helper functions for devfreq user device driver with OPP. */ > extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, > unsigned long *freq, u32 flags); >
Reviewed-by: Chanwoo Choi <[email protected]> -- Best Regards, Chanwoo Choi Samsung Electronics
