From: Roman Kiryanov <[email protected]> checkpatch.pl complained about missing blank lines (between variable definitions and executable code) and using just "unsigned" instead of "unsigned int".
Signed-off-by: Roman Kiryanov <[email protected]> --- Changes in v2: - Updated the commit message. drivers/tty/goldfish.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index 37caba7c3aff..a92fcb2b0002 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -172,6 +172,7 @@ static void goldfish_tty_shutdown(struct tty_port *port) static int goldfish_tty_open(struct tty_struct *tty, struct file *filp) { struct goldfish_tty *qtty = &goldfish_ttys[tty->index]; + return tty_port_open(&qtty->port, tty, filp); } @@ -201,11 +202,12 @@ static int goldfish_tty_chars_in_buffer(struct tty_struct *tty) { struct goldfish_tty *qtty = &goldfish_ttys[tty->index]; void __iomem *base = qtty->base; + return readl(base + GOLDFISH_TTY_REG_BYTES_READY); } static void goldfish_tty_console_write(struct console *co, const char *b, - unsigned count) + unsigned int count) { goldfish_tty_do_write(co->index, b, count); } @@ -219,7 +221,7 @@ static struct tty_driver *goldfish_tty_console_device(struct console *c, static int goldfish_tty_console_setup(struct console *co, char *options) { - if ((unsigned)co->index >= goldfish_tty_line_count) + if ((unsigned int)co->index >= goldfish_tty_line_count) return -ENODEV; if (!goldfish_ttys[co->index].base) return -ENODEV; -- 2.18.0.233.g985f88cf7e-goog
