On Sun, Jul 22, 2018 at 04:03:58PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <[email protected]> > > Building drivers/mtd/nand/raw/nandsim.c on arch/hexagon/ produces a > printk format build warning. This is due to hexagon's ffs() being > coded as returning long instead of int. > > Fix the printk format warning by changing all of hexagon's ffs() and > fls() functions to return int instead of long. The variables that > they return are already int instead of long. This return type > matches the return type in <asm-generic/bitops/>. > > ../drivers/mtd/nand/raw/nandsim.c: In function 'init_nandsim': > ../drivers/mtd/nand/raw/nandsim.c:760:2: warning: format '%u' expects > argument of type 'unsigned int', but argument 2 has type 'long int' [-Wformat] > > There are no ffs() or fls() allmodconfig build errors after making this > change. > > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Richard Kuo <[email protected]> > Cc: [email protected] > Cc: Geert Uytterhoeven <[email protected]> > --- > v2: > add hexagon contacts, drop erroneous sh contacts; [thanks, Geert] > only change return type for ffs() and fls() [thanks, Geert] > [drop the changes for ffz(), __ffs(), and __fls()] > > arch/hexagon/include/asm/bitops.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Acked-by: Richard Kuo <[email protected]> -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
