mdelay() is not a preferred API to be used to insert delay in the kernel code unless the context is atomic. Instead, msleep() API can be used. This patch introduces this warning.
Signed-off-by: Israel Schlesinger <[email protected]> Signed-off-by: Stepan Moskovchenko <[email protected]> Signed-off-by: Prakruthi Deepak Heragu <[email protected]> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a9c0550..14bba3f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5572,6 +5572,12 @@ sub process { "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr); } +# check the patch for use of mdelay + if ($line =~ /\bmdelay\s*\(/) { + WARN("MDELAY", + "use of mdelay() found: msleep() is the preferred API.\n" . $herecurr ); + } + # warn about #ifdefs in C files # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { # print "#ifdef in C files should be avoided\n"; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
