* Belisko Marek <[email protected]> [180620 09:40]: > Hello, > > I'm trying to fix warning (for omap5 board) produced by recent change > to avoid using IRQ_TYPE_NONE like: > [ 1.818666] WARNING: CPU: 1 PID: 778 at > drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0x78/0x100 > [ 1.828839] Modules linked in: > > I did look to other commit which did update and without deep knowledge > I just simply do this small change: > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi > b/arch/arm/boot/dts/omap5-board-common.dtsi > index 218892b..ab2df8c 100644 > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > @@ -393,7 +393,7 @@ > > palmas: palmas@48 { > compatible = "ti,palmas"; > - interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* IRQ_SYS_1N */ > + interrupts = <GIC_SPI 7 IRQ_TYPE_HIGH>; /* IRQ_SYS_1N */ > reg = <0x48>; > interrupt-controller; > #interrupt-cells = <2>; > > and it looks board boots fine. Only issue is that gpadc driver is not > working (at least not getting interrupts at all ADC fails with > timeout). I did look to gpadc driver and driver is not using > interrupts defined in dts but request interrupt directly from palmas > mfd module. Any ideas what needs to be changed to have gpadc again > working with mentioned patch?
Can you try with IRQF_TRIGGER_HIGH added also to the flags to regmap_add_irq_chip() in drivers/mfd/palmas.c? Regards, Tony
