Hi, On Mon, Jul 2, 2018 at 11:10 AM, Matthias Kaehlcke <[email protected]> wrote: > This adds the spmi-temp-alarm node to pm8998 based on the examples in the > bindings. > > Signed-off-by: Matthias Kaehlcke <[email protected]> > --- > Changes in v2: > - none > > arch/arm64/boot/dts/qcom/pm8998.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi > b/arch/arm64/boot/dts/qcom/pm8998.dtsi > index 92bed1e7d4bb..2f4989e7ef68 100644 > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi > @@ -11,6 +11,13 @@ > #address-cells = <1>; > #size-cells = <0>; > > + pm8998_temp: qcom,temp-alarm@2400 {
Remove "qcom," from the node name (AKA please change to "temp-alarm@2400"). Someone internal in Qualcomm seems to have started this trend so you see it on all downstream kernels, but upstream device tree isn't supposed to have it. > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400 0x100>; Why are there two numbers for the "reg"? Should just be 0x2400. -Doug
