Hi, On Tue, Jun 26, 2018 at 12:44 AM, Jason Gunthorpe <[email protected]> wrote: > The true option causes this indenting for functions: > > static struct something_very_very_long * > function(void *arg) > { > > While a quick survey suggests that the usual Linux fallback is the GNU > style: > > static struct something_very_very_long * > function(void *arg) > { > > Eg as seen in: > > kernel/cpu.c > kernel/fork.c > etc > > Acked-by: Joe Perches <[email protected]> > Signed-off-by: Jason Gunthorpe <[email protected]> > --- > .clang-format | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Resending outside the merge window with no change.. > > If there is no clear upstream path for this file (it has no > MAINTAINERS entry?) I could take it to Linus via the rdma.git tree, eg
We can add an specific entry, yeah. Is there any policy for "general files" (or some general/catch-all entry)? > as a 'collectively maintained' file. As you prefer -- I can also pick it up through auxdisplay; but I am not sure if we should put it in any "unrelated" tree, though. (Since the file will not probably receive many patches, I originally thought that it would be picked up by Andrew or some other "general" tree instead.) > > Would prefer Miguel's Ack to do that though. Looks like Andrew Morton > took the original patch introducing the file? Yep, I sent it to Andrew and he kindly picked it up. Probably he didn't notice this one. As for the patch: Acked-by: Miguel Ojeda <[email protected]> Cheers, Miguel > > Thanks, > Jason > > diff --git a/.clang-format b/.clang-format > index faffc0d5af4eeb..1d5da22e0ba50c 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -382,7 +382,7 @@ IncludeIsMainRegex: '(Test)?$' > IndentCaseLabels: false > #IndentPPDirectives: None # Unknown to clang-format-5.0 > IndentWidth: 8 > -IndentWrappedFunctionNames: true > +IndentWrappedFunctionNames: false > JavaScriptQuotes: Leave > JavaScriptWrapImports: true > KeepEmptyLinesAtTheStartOfBlocks: false > -- > 2.17.0 >
