On Mon, Jun 4, 2018 at 12:46 PM, Mark Brown <[email protected]> wrote: > On Fri, Jun 01, 2018 at 12:49:53AM +0200, Janusz Krzysztofik wrote: > >> I confirm the fix by Stephen works for me, however, the conflicting patch by >> Linus breaks things a bit. > >> Lookup tables added to board files use function name "enable" while the >> regulator uses NULL. As a result, GPIO descriptor is not matched and not >> assigned to the regulator which ends up running with no control over GPIO >> pin. > >> Either the regulator driver should use the function name "enable" or that >> name >> should be removed from lookup tables. > > I'll revert this one as well :(
I see this is a generic problem, no idea why I didn't pass these unnamed as NULL in the first place, probably my ignorance as usual. I fixed it up in my patch making them all anonymous and rebasing the rest as well. Let's see how it looks after the merge window. I will also need to rebase on top of Janusz changes and then it will look even better. Janusz: would be super if you could test my patches after that! Yours, Linus Walleij

