On Wed, May 23, 2018 at 1:42 PM, Marek Vasut <[email protected]> wrote: > The model number stored in the struct da9063 is the same for all > variants of the da9063 since it is the chip ID, which is always > the same. Replace that with a separate identifier instead, which > allows us to discern the DA9063 variants by setting the type > based on either DT match or otherwise. > > Signed-off-by: Marek Vasut <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]> > --- a/drivers/mfd/da9063-i2c.c > +++ b/drivers/mfd/da9063-i2c.c > @@ -248,6 +248,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c, > i2c_set_clientdata(i2c, da9063); > da9063->dev = &i2c->dev; > da9063->chip_irq = i2c->irq; > + da9063->type = (enum da9063_type)id->driver_data; Nit: I think this cast (from unsigned long) is not needed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
