Hi Andrzej, I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next] [also build test ERROR on v4.17-rc5 next-20180511] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andrzej-Hajda/PM-core-refactor-PM_OPS-initializers/20180514-172201 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: ia64-defconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=ia64 All error/warnings (new ones prefixed by >>): In file included from include/linux/device.h:23:0, from include/linux/pci.h:31, from drivers/net//ethernet/broadcom/tg3.c:33: >> drivers/net//ethernet/broadcom/tg3.c:18150:38: error: 'tg3_suspend' >> undeclared here (not in a function); did you mean 'phy_suspend'? static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); ^ include/linux/pm.h:316:59: note: in definition of macro 'PM_SLEEP_PTR' #define PM_SLEEP_PTR(ptr) (IS_ENABLED(CONFIG_PM_SLEEP) ? (ptr) : NULL) ^~~ include/linux/pm.h:354:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS' SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net//ethernet/broadcom/tg3.c:18150:8: note: in expansion of macro >> 'SIMPLE_DEV_PM_OPS' static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); ^~~~~~~~~~~~~~~~~ >> drivers/net//ethernet/broadcom/tg3.c:18150:51: error: 'tg3_resume' >> undeclared here (not in a function); did you mean 'phy_resume'? static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); ^ include/linux/pm.h:316:59: note: in definition of macro 'PM_SLEEP_PTR' #define PM_SLEEP_PTR(ptr) (IS_ENABLED(CONFIG_PM_SLEEP) ? (ptr) : NULL) ^~~ include/linux/pm.h:354:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS' SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net//ethernet/broadcom/tg3.c:18150:8: note: in expansion of macro >> 'SIMPLE_DEV_PM_OPS' static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); ^~~~~~~~~~~~~~~~~ -- In file included from include/linux/device.h:23:0, from drivers/video//backlight/backlight.c:12: >> drivers/video//backlight/backlight.c:280:54: error: 'backlight_suspend' >> undeclared here (not in a function); did you mean 'backlight_types'? static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, ^ include/linux/pm.h:316:59: note: in definition of macro 'PM_SLEEP_PTR' #define PM_SLEEP_PTR(ptr) (IS_ENABLED(CONFIG_PM_SLEEP) ? (ptr) : NULL) ^~~ include/linux/pm.h:354:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS' SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ ^~~~~~~~~~~~~~~~~~~~~~~ drivers/video//backlight/backlight.c:280:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS' static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, ^~~~~~~~~~~~~~~~~ >> drivers/video//backlight/backlight.c:281:5: error: 'backlight_resume' >> undeclared here (not in a function); did you mean 'backlight_device'? backlight_resume); ^ include/linux/pm.h:316:59: note: in definition of macro 'PM_SLEEP_PTR' #define PM_SLEEP_PTR(ptr) (IS_ENABLED(CONFIG_PM_SLEEP) ? (ptr) : NULL) ^~~ include/linux/pm.h:354:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS' SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ ^~~~~~~~~~~~~~~~~~~~~~~ drivers/video//backlight/backlight.c:280:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS' static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, ^~~~~~~~~~~~~~~~~ vim +18150 drivers/net//ethernet/broadcom/tg3.c ^1da177e drivers/net/tg3.c Linus Torvalds 2005-04-16 18149 c866b7ea drivers/net/tg3.c Rafael J. Wysocki 2010-12-25 @18150 static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); c866b7ea drivers/net/tg3.c Rafael J. Wysocki 2010-12-25 18151 :::::: The code at line 18150 was first introduced by commit :::::: c866b7eac073198cef03ea6bac2dc978635a9f5c tg3: Do not use legacy PCI power management :::::: TO: Rafael J. Wysocki <[email protected]> :::::: CC: David S. Miller <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
