On Tue, Apr 10, 2018 at 07:13:23PM +0900, Tetsuo Handa wrote: > syzbot is reporting NULL pointer dereference at xattr_getsecurity() [1], > for cap_inode_getsecurity() is returning sizeof(struct vfs_cap_data) when > memory allocation failed. Return -ENOMEM if memory allocation failed. > > [1] > https://syzkaller.appspot.com/bug?id=a55ba438506fe68649a5f50d2d82d56b365e0107 > > Signed-off-by: Tetsuo Handa <[email protected]> > Fixes: 8db6c34f1dbc8e06 ("Introduce v3 namespaced file capabilities") > Reported-by: syzbot <[email protected]> > Cc: stable <[email protected]> # 4.14+ > Cc: Serge E. Hallyn <[email protected]>
Acked-by: Serge Hallyn <[email protected]> thanks! -serge > Cc: Eric W. Biederman <[email protected]> > --- > security/commoncap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/security/commoncap.c b/security/commoncap.c > index 48620c9..1ce701f 100644 > --- a/security/commoncap.c > +++ b/security/commoncap.c > @@ -449,6 +449,8 @@ int cap_inode_getsecurity(struct inode *inode, const char > *name, void **buffer, > magic |= VFS_CAP_FLAGS_EFFECTIVE; > memcpy(&cap->data, &nscap->data, sizeof(__le32) * 2 * > VFS_CAP_U32); > cap->magic_etc = cpu_to_le32(magic); > + } else { > + size = -ENOMEM; > } > } > kfree(tmpbuf); > -- > 1.8.3.1
