On 2007.05.29 10:18:48 +0000, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote:
> > +static const struct intel_driver_description {
> > + unsigned int chip_id;
> > + unsigned int gmch_chip_id;
> > + char *name;
> > + struct agp_bridge_driver *driver;
> > + struct agp_bridge_driver *gmch_driver;
>
> The two should be const to avoid the silly casts below.
>
> > + for (i = 0; intel_agp_chipsets[i].name != NULL; i++) {
> > + if (pdev->device == intel_agp_chipsets[i].chip_id)
> > + break;
>
> please use tabs for indentation.
>
I'll fix those problems in next submit, thank you for review.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
