On 22.02.2018 01:28, Kees Cook wrote: > The header files for some structures could get included in such a way > that struct attributes (specifically __randomize_layout from path.h) would > be parsed as variable names instead of attributes. This could lead to > some instances of a structure being unrandomized, causing nasty GPFs, etc. > > This patch makes sure the compiler_types.h header is included in > kconfig.h so that we've always got types and struct attributes defined, > since kconfig.h is included from the compiler command line. > > Reported-by: Patrick McLean <[email protected]> > Root-caused-by: Maciej S. Szmigiero <[email protected]> > Fixes: 3859a271a003 ("randstruct: Mark various structs for randomization") > Suggested-by: Linus Torvalds <[email protected]> > Signed-off-by: Kees Cook <[email protected]>
I can confirm that this patch fixes the original nfsd GPF issue. Also, struct path members offsets are consistent now between nfs4xdr.s and other files. > --- > Updated Maciej's tag. Thanks. Maciej
