On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne <[email protected]> wrote: > Miguel, > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > <[email protected]> wrote: >> Cc: Willy Tarreau <[email protected]> >> Cc: Geert Uytterhoeven <[email protected]> >> Cc: Linus Walleij <[email protected]> >> Cc: Robin van der Gracht <[email protected]> >> Cc: Paul Burton <[email protected]> >> Signed-off-by: Miguel Ojeda <[email protected]> >> --- > > <snip> > >> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h >> index b454dfce60d9..aa960efc32f6 100644 >> --- a/include/linux/cfag12864b.h >> +++ b/include/linux/cfag12864b.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Per the doc [1] you should be using instead this in a .h: > /* SPDX-License-Identifier: GPL-2.0 */ > > I know this can be surprising. This has been discussed on list quite > lot and the doc has some rationale.
Thanks for taking the time to check the patch. It was a mistake on my side -- I had actually read the docs but I recalled Linus talking about moving to // at some point (and somehow my brain recorded that the discussion was about the headers :-), so I thought I was actually doing the right thing by using // already. Don't worry, I will fix it when I put it in the queue. Cheers, Miguel > > <snip> > >> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h >> index cb311798e0bc..2a1c985fedea 100644 >> --- a/include/linux/ks0108.h >> +++ b/include/linux/ks0108.h >> @@ -1,25 +1,11 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Same comment as above. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > > -- > Cordially > Philippe Ombredanne
