On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > Following a suggestion from Bjorn Andersson [1], this commit moves > electrical specifications which were defined in mms8916-pins.dtsi to > board files, where they actually belong. > > Pinmuxing is kept in the platform file because there are no alternative > pins on which all these functions could be routed, so this part is > indeed common to all boards using this SoC. > > [1] https://www.spinics.net/lists/devicetree/msg201764.html > > Signed-off-by: Damien Riegel <[email protected]> > Suggested-by: Bjorn Andersson <[email protected]>
I like the move, but I would prefer that you mimic the base structure, rather than just appending properties based on labels. Regards, Bjorn
