Steven, On Sat, Dec 9, 2017 at 11:42 PM, Steven Eckhoff <[email protected]> wrote: > Currently there is no support for the TSCS42xx audio CODEC. > > Add support for it. > > Below is the link to the v2 patch in case the threading is broken. This > patch addressed each issue raised in the last review. > > https://patchwork.kernel.org/patch/10058117/ > > Signed-off-by: Steven Eckhoff <[email protected]> > Cc: Steven Eckhoff <[email protected]> > Cc: Liam Girdwood <[email protected]> > Cc: Mark Brown <[email protected]> > Cc: Jaroslav Kysela <[email protected]> > Cc: Takashi Iwai <[email protected]> > Cc: [email protected] > Cc: [email protected] [...] > --- /dev/null > +++ b/sound/soc/codecs/tscs42xx.c > @@ -0,0 +1,1571 @@ > +/* > + * tscs42xx.c -- TSCS42xx ALSA SoC Audio driver > + * > + * Copyright 2017 Tempo Semiconductor, Inc. > + * > + * Author: Steven Eckhoff <[email protected]> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */
Have you considered using the new SPDX ids? This would come out as: > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * tscs42xx.c -- TSCS42xx ALSA SoC Audio driver > + * > + * Copyright 2017 Tempo Semiconductor, Inc. > + * > + * Author: Steven Eckhoff <[email protected]> > + */ ... and is shorter and greppable: there is nothing not to like in this, unless you love legalese of course! Check also Thomas doc patches and Linus rationale of why he wants this as the top line using C++-style comments. And if you agree like me with Linus take on C++ comments, you could even go with less boilerplate with this: > +// SPDX-License-Identifier: GPL-2.0 > +// tscs42xx.c -- TSCS42xx ALSA SoC Audio driver > +// Copyright 2017 Tempo Semiconductor, Inc. > +// Author: Steven Eckhoff <[email protected]> This would make 12 lines of comment be just 4 .... with the same effect, but less distraction from your fine code. Thank you for your kind consideration! -- Cordially Philippe Ombredanne
