On Tue, Oct 17, 2017 at 04:18:18PM +0800, Huang, Ying wrote: > From: Huang Ying <[email protected]> > > Now, when the page table is walked in the implementation of > /proc/<pid>/pagemap, pmd_soft_dirty() is used for both the PMD huge > page map and the PMD migration entries. That is wrong, > pmd_swp_soft_dirty() should be used for the PMD migration entries > instead because the different page table entry flag is used. > > Cc: Michal Hocko <[email protected]> > Cc: "Kirill A. Shutemov" <[email protected]> > Cc: David Rientjes <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Hugh Dickins <[email protected]> > Cc: "Jérôme Glisse" <[email protected]> > Cc: Daniel Colascione <[email protected]> > Cc: Zi Yan <[email protected]> > Cc: Naoya Horiguchi <[email protected]> > Signed-off-by: "Huang, Ying" <[email protected]>
What is effect of the misbehaviour? pagemap reports garbage? Shoudn't it be in stable@? And maybe add Fixes: <sha1>. Otherwise, looks good to me. Acked-by: Kirill A. Shutemov <[email protected]> -- Kirill A. Shutemov
