(adding Michal)

On Mon, Aug 07, 2017 at 04:12:25PM +0300, Mike Rapoport wrote:
> When the process exit races with outstanding mcopy_atomic, it would be
> better to return ESRCH error. When such race occurs the process and it's mm
> are going away and returning "no such process" to the uffd monitor seems
> better fit than ENOSPC.
> 
> Suggested-by: Michal Hocko <[email protected]>
> Cc: Andrea Arcangeli <[email protected]>
> Cc: "Dr. David Alan Gilbert" <[email protected]>
> Cc: Pavel Emelyanov <[email protected]>
> Cc: Mike Kravetz <[email protected]>
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> The man-pages update is ready and I'll send it out once the patch is
> merged.
> 
>  fs/userfaultfd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
> index 06ea26b8c996..b0d5897bc4e6 100644
> --- a/fs/userfaultfd.c
> +++ b/fs/userfaultfd.c
> @@ -1600,7 +1600,7 @@ static int userfaultfd_copy(struct userfaultfd_ctx *ctx,
>                                  uffdio_copy.len);
>               mmput(ctx->mm);
>       } else {
> -             return -ENOSPC;
> +             return -ESRCH;
>       }
>       if (unlikely(put_user(ret, &user_uffdio_copy->copy)))
>               return -EFAULT;
> @@ -1647,7 +1647,7 @@ static int userfaultfd_zeropage(struct userfaultfd_ctx 
> *ctx,
>                                    uffdio_zeropage.range.len);
>               mmput(ctx->mm);
>       } else {
> -             return -ENOSPC;
> +             return -ESRCH;
>       }
>       if (unlikely(put_user(ret, &user_uffdio_zeropage->zeropage)))
>               return -EFAULT;
> -- 
> 2.7.4
> 

-- 
Sincerely yours,
Mike.

Reply via email to